Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Update CSS fragmentation introduction #15621

Merged
merged 6 commits into from
Sep 5, 2023
Merged

[zh-cn] Update CSS fragmentation introduction #15621

merged 6 commits into from
Sep 5, 2023

Conversation

jasonren0403
Copy link
Contributor

Description

revise translation of 'inline' and update the document

Motivation

Additional details

Related issues and pull requests

Part of #12632

@jasonren0403 jasonren0403 requested a review from a team as a code owner September 4, 2023 13:30
@jasonren0403 jasonren0403 requested review from yin1999 and removed request for a team September 4, 2023 13:30
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Sep 4, 2023
@jasonren0403 jasonren0403 mentioned this pull request Sep 4, 2023
Open
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

Preview URLs

Flaws (2)

URL: /zh-CN/docs/Web/CSS/CSS_fragmentation
Title: CSS 片段
Flaw count: 2

  • macros:
    • /zh-CN/docs/Web/CSS/break-before does not exist but fell back to /en-US/docs/Web/CSS/break-before
    • /zh-CN/docs/Web/CSS/orphans does not exist but fell back to /en-US/docs/Web/CSS/orphans

(comment last updated: 2023-09-05 01:44:15)

@jasonren0403
Copy link
Contributor Author

'lint-and-review-docs' isn't running well 🤔 I'm not sure why... @yin1999
image

@yin1999
Copy link
Member

yin1999 commented Sep 4, 2023 •
edited
Loading

'lint-and-review-docs' isn't running well 🤔 I'm not sure why... @yin1999 image

It seems like the new release of action/checkout has affected the operation of workflows.

Issue mentioned here: actions/checkout#1448.

yin1999
yin1999 reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments here

files/zh-cn/web/css/css_fragmentation/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/css_fragmentation/index.md Outdated Show resolved Hide resolved
@jasonren0403 @yin1999
Apply suggestions from code review
2d79761 
Co-authored-by: A1lo <yin199909@aliyun.com>
@jasonren0403 jasonren0403 requested a review from yin1999 September 4, 2023 15:03
yin1999
yin1999 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't explain clearly. Please consider this. If it makes sense to you, just go ahead and merge this.

Thanks @jasonren0403

files/zh-cn/web/css/css_fragmentation/index.md Outdated Show resolved Hide resolved
@jasonren0403 @yin1999
Update files/zh-cn/web/css/css_fragmentation/index.md
815b0c4 
Co-authored-by: A1lo <yin199909@aliyun.com>
@jasonren0403 jasonren0403 merged commit 41b3960 into main Sep 5, 2023
@jasonren0403 jasonren0403 deleted the jasonren0403-css-frag-intro branch September 5, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonren0403 @yin1999