Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync with english version for margin collapsing #14279

Merged
merged 4 commits into from
Jul 18, 2023
Merged

sync with english version for margin collapsing #14279

merged 4 commits into from
Jul 18, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Jul 16, 2023

Description

sync with english version for margin collapsing

Related issues and pull requests

Fixes: #14054

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/CSS/CSS_box_model/Mastering_margin_collapsing
Title: 掌握外边距折叠
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

(comment last updated: 2023-07-18 15:22:19)

@yin1999 yin1999 marked this pull request as ready for review July 16, 2023 04:15
@yin1999 yin1999 requested a review from a team as a code owner July 16, 2023 04:15
@yin1999 yin1999 requested review from t7yang and removed request for a team July 16, 2023 04:15
@jasonren0403 jasonren0403 mentioned this pull request Jul 16, 2023
Open
@yin1999 yin1999 requested a review from jasonren0403 July 18, 2023 01:37
jasonren0403
jasonren0403 reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

files/zh-cn/web/css/css_box_model/mastering_margin_collapsing/index.md Show resolved Hide resolved
@yin1999 yin1999 requested a review from jasonren0403 July 18, 2023 15:20
jasonren0403
jasonren0403 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jasonren0403 jasonren0403 merged commit ae84eda into mdn:main Jul 18, 2023
@yin1999 yin1999 deleted the collapsing branch July 18, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

第一种情况处，中文翻译的内容有点歧义
2 participants
@yin1999 @jasonren0403