Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Tidy up ingredient handlers #511

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented Jul 10, 2020

Thanks to our recent work on ingredient handlers, we've done some refactoring. But it's been a bit incomplete, leading to inconsistencies in the way we've organized them. This is a first step toward making it more obvious where ingredient handlers come from and how they're composed.

Unfortunately, this leads to a bit of a grab bag of changes. I tried to show some restraint though. The changes that happened here:

  1. The ordinary prose handlers now reuse the sectionHandler code used in other ingredients. 9c51c10 makes the change and 640c754 moves them alongside another handler wrapper. This is probably the most substantial thing, since it trims some duplicate code.
  2. The link list checker has been refactored to provide an API closer to sectionHandler etc. See ddc64e8.
  3. I split the class member handlers into their own files in dad2ac8. This makes it clearer which modules contain concrete ingredient handlers and which contain utilities (there's still a lot more work to do be done in this area—and utils could probably stand to be broken up or export informative namespaces).
  4. With that, I was able to make registering new ingredients less repetitious in 7d13da1.

There's more to be done, but this is a start.

@ddbeck ddbeck requested a review from a team July 10, 2020 17:01
@Elchi3 Elchi3 removed the request for review from a team February 18, 2021 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant