Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): Add example of <dialog> #2212

Merged
merged 4 commits into from
Aug 18, 2023
Merged

feat(html): Add example of <dialog> #2212

merged 4 commits into from
Aug 18, 2023

Conversation

NiedziolkaMichal
Copy link
Member

@NiedziolkaMichal NiedziolkaMichal commented Jul 11, 2022 •
edited
Loading

It's interactive example for dialog element.

image

image

image

@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Nov 18, 2022
Merged
1 task
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Dec 25, 2022
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 10, 2023
Open
94 tasks
@NiedziolkaMichal NiedziolkaMichal removed depends on shadow DOM fix merge conflicts 🚧 idle Issues and pull requests with no activity for three months. labels Feb 26, 2023
@NiedziolkaMichal NiedziolkaMichal changed the title dialog feat(html): Add example of <dialog> Feb 26, 2023
@NiedziolkaMichal NiedziolkaMichal changed the title feat(html): Add example of <dialog> feat(html): Add example of <dialog> Feb 26, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 29, 2023
@Josh-Cena Josh-Cena added the Content:HTML issues related to HTML examples. label Jul 31, 2023
@github-actions github-actions bot added merge conflicts 🚧 and removed idle Issues and pull requests with no activity for three months. labels Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@bsmth bsmth requested a review from a team as a code owner August 18, 2023 13:45
@bsmth bsmth requested review from estelle and removed request for a team August 18, 2023 13:45
bsmth
bsmth approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NiedziolkaMichal! Merging shortly 👍🏻

@bsmth bsmth merged commit e97aa1d into mdn:main Aug 18, 2023
@mdn-bot mdn-bot mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML issues related to HTML examples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NiedziolkaMichal @bsmth @wbamberg @Josh-Cena @queengooborg