Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF90: Add info about EXIF intrinsic size (basic) #6798

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

hamishwillee
Copy link
Collaborator

In FF90 Firefox now respects EXIF information about the intrinsic size of an image (see #6240). Essentially this replaces the HTTP Content-DPR header, which allowed a server to specify the intrinsic size of an image. This is useful because (among other reasons) it means a server can send a low quality placeholder image if needed and it will render with exactly the same layout as the original - so nothing gets stuff up when you lazily load the proper one.

This is bare minimal (I hope) docs to capture the fact of this change, without providing much of the detail. I'm hoping perhaps we can get this in for the release and then iterate following discussion. What it does is:

  • State the change in the release notes, with a link to the bug and the explainer.
  • Provide a glossary doc for EXIF - just so I don't have to explain it again and have a place to link to specs etc.
  • Provide a bit of info about what intrinsic size "means" for images. The spec really doesn't cover this at all to my mind https://www.w3.org/TR/css-sizing-3/#intrinsic-sizes

More generally what do we need?

  • MDN does not (IMO) properly/well define the meaning of a the various terms used around images and image sizes - specifically there is no one clear place where you can go to understand what the intrinsic size really means and how other properties of an image and device relate (device pixels, CSS pixels, pixel density, etc). I think everyone who has done this before already had a good understanding because I'm finding it very confusing.
  • The EXIF changes only become more relevant as the HTTP Client headers are adopted. These are still not implemented anywhere.
  • I think we need to say exactly what fields in the EXIF need to be set. There is some discussion of that here Allow an image to indicate its own density and correct its intrinsic size whatwg/html#5574 - sounds like we need all four of PixelXDimension, PixelYDimension, ResolutionX, and ResolutionY, ... and ResolutionUnit.

@hamishwillee hamishwillee requested a review from a team as a code owner July 12, 2021 07:33
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team July 12, 2021 07:33
@github-actions
Copy link
Contributor

Copy link
Collaborator

@Rumyra Rumyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you @hamishwillee 🙌

I've started a Content Work project, so feel free to add any other tasks surrounding this work in there

@Rumyra Rumyra merged commit f8090e9 into mdn:main Jul 12, 2021
@hamishwillee hamishwillee deleted the ff90_exif branch July 12, 2021 22:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants