Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #5261, missing parenthesis in image() url() example. #5283

Merged
merged 1 commit into from
May 25, 2021
Merged

Fix issue #5261, missing parenthesis in image() url() example. #5283

merged 1 commit into from
May 25, 2021

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented May 25, 2021 •
edited
Loading

Fix the 3 flawed cssxref macros at the end of the page.

What was wrong/why is this fix needed? (quick summary only)

A missing parenthesis in the image(url(…), …) example.
3 cssxref macros were marked as flawed

MDN URL of the main page changed

https://developer.mozilla.org/en-US/docs/Web/CSS/url()

Issue number (if there is an associated issue)
Fix #5261

Anything else that could help us review it

@teoli2003
Fix issue mdn#5261, missing parenthesis in image() url() example.
e5cf230 
Fix the 3 flawed cssxref macros at the end of the page.
@teoli2003 teoli2003 requested a review from a team as a code owner May 25, 2021 11:29
@teoli2003 teoli2003 requested review from mirunacurtean and removed request for a team May 25, 2021 11:29
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/CSS/url()
Title: url()
on GitHub

No new external URLs

mirunacurtean
mirunacurtean approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@mirunacurtean mirunacurtean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Looks good to me.

@mirunacurtean mirunacurtean merged commit dd77a55 into mdn:main May 25, 2021
@teoli2003 teoli2003 deleted the Issue-#5261 branch May 25, 2021 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mirunacurtean mirunacurtean mirunacurtean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "url()": Missing parenthesis in demo code
2 participants
@teoli2003 @mirunacurtean