Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Page macro: ScriptProcessorNode examples #5238

Merged
merged 1 commit into from
May 25, 2021

Conversation

hamishwillee
Copy link
Collaborator

Partial fix to : #3196

Replaces inclusion of example at BaseAudioContext.createScriptProcessor with linking for ScriptProcessorNode and a few other pages (e.g.).

Note, as last time we did this @wbamberg I haven't tried to create or find a great example. Merely to remove the unwanted inclusion in a way that is no worse than the current situation. While I was here took the time to import BCD in page frontmatter.

@hamishwillee hamishwillee requested a review from a team as a code owner May 24, 2021 05:13
@hamishwillee hamishwillee requested review from jpmedley and wbamberg and removed request for a team May 24, 2021 05:13
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/ScriptProcessorNode
Title: ScriptProcessorNode
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/ScriptProcessorNode/onaudioprocess
Title: ScriptProcessorNode.onaudioprocess
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/ScriptProcessorNode/bufferSize
Title: ScriptProcessorNode.bufferSize
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/audionodepassthrough (url: /en-US/docs/Web/API/AudioNodePassThrough) does not exist

URL: /en-US/docs/Web/API/AudioProcessingEvent
Title: AudioProcessingEvent
on GitHub
Flaw count: 4

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/ScriptProcessorNode
Title: ScriptProcessorNode
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ScriptProcessorNode/onaudioprocess
Title: ScriptProcessorNode.onaudioprocess
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/ScriptProcessorNode/bufferSize
Title: ScriptProcessorNode.bufferSize
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AudioProcessingEvent
Title: AudioProcessingEvent
on GitHub

@hamishwillee
Copy link
Collaborator Author

@chrisdavidmills Great if you could look at this one.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good; thanks @hamishwillee !

@chrisdavidmills chrisdavidmills merged commit 16a7bae into mdn:main May 25, 2021
@hamishwillee hamishwillee deleted the pagemacro_scriptprocessor branch May 25, 2021 23:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants