Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Page macro from native messaging doc #5230

Merged
merged 1 commit into from
May 24, 2021
Merged

Remove Page macro from native messaging doc #5230

merged 1 commit into from
May 24, 2021

Conversation

hamishwillee
Copy link
Collaborator

Partial fix to #3196

This replaces inclusion of Chrome incompatibilities > native messaging section into the web extension Native messaging topic with a link.

Obviously it would be more useful to have the content included, but not worth the duplication.

@hamishwillee hamishwillee requested a review from a team as a code owner May 24, 2021 02:54
@hamishwillee hamishwillee requested review from caitmuenster and wbamberg and removed request for a team May 24, 2021 02:54
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging
Title: Native messaging
on GitHub

wbamberg
wbamberg approved these changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishwillee ! Looks good to me.

caitmuenster
caitmuenster approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@caitmuenster caitmuenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hamishwillee.

@caitmuenster caitmuenster merged commit fac4ed4 into mdn:main May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caitmuenster caitmuenster caitmuenster approved these changes

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishwillee @wbamberg @caitmuenster