Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigator.getBattery() is not deprecated #5227

Merged
merged 3 commits into from
May 25, 2021
Merged

navigator.getBattery() is not deprecated #5227

merged 3 commits into from
May 25, 2021

Conversation

hamishwillee
Copy link
Collaborator

Fixes #5200

This removes the deprecation notice on https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getBattery and also adds a link to this method from the parent (Navigator).

The BCD previously also incorrectly marked this as deprecated. That was fixed in mdn/browser-compat-data#9626 : "Don't claim it's deprecated, https://w3c.github.io/battery/ is still a "real" spec and Chromium hasn't deprecated it."

@hamishwillee hamishwillee requested a review from a team as a code owner May 24, 2021 01:29
@hamishwillee hamishwillee requested review from jpmedley and removed request for a team May 24, 2021 01:29
@hamishwillee hamishwillee mentioned this pull request May 24, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Navigator
Title: Navigator
on GitHub
Flaw count: 16

  • macros:
    • /en-us/docs/web/api/navigatorcontentutils (url: /en-US/docs/Web/API/NavigatorContentUtils) does not exist
    • /en-us/docs/web/api/navigatorstorageutils (url: /en-US/docs/Web/API/NavigatorStorageUtils) does not exist
    • /en-us/docs/web/api/navigatorfeatures (url: /en-US/docs/Web/API/NavigatorFeatures) does not exist
    • /en-us/docs/web/api/navigatorbattery (url: /en-US/docs/Web/API/NavigatorBattery) does not exist
    • /en-us/docs/web/api/navigatordatastore (url: /en-US/docs/Web/API/NavigatorDataStore) does not exist
    • and 10 more flaws omitted
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/Navigator/getBattery
Title: Navigator.getBattery()
on GitHub
Flaw count: 6

  • macros:
    • /en-us/docs/web/api/navigatorcontentutils (url: /en-US/docs/Web/API/NavigatorContentUtils) does not exist
    • /en-us/docs/web/api/navigatorstorageutils (url: /en-US/docs/Web/API/NavigatorStorageUtils) does not exist
    • /en-us/docs/web/api/navigatorfeatures (url: /en-US/docs/Web/API/NavigatorFeatures) does not exist
    • /en-us/docs/web/api/navigatorbattery (url: /en-US/docs/Web/API/NavigatorBattery) does not exist
    • /en-us/docs/web/api/navigatordatastore (url: /en-US/docs/Web/API/NavigatorDataStore) does not exist
    • and 1 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/Navigator
Title: Navigator
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Navigator/getBattery
Title: Navigator.getBattery()
on GitHub

No new external URLs

(this comment was updated 2021-05-25 00:34:24.614415)

jpmedley
jpmedley requested changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission.

files/en-us/web/api/navigator/index.html Outdated Show resolved Hide resolved
hamishwillee and others added 2 commits May 25, 2021 10:28
@hamishwillee hamishwillee requested a review from jpmedley May 25, 2021 00:33
@jpmedley jpmedley merged commit d0a20d2 into mdn:main May 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpmedley jpmedley jpmedley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "Navigator.getBattery()": Deprecation Notice seems inappropriate.
2 participants
@hamishwillee @jpmedley