Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecation with warning in hgroup #4977

Merged
merged 4 commits into from
May 14, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 13, 2021

This changes the deprecation at top of the hgroup to a warning note. The reason is that while the API should not be used until it properly supports assistive technologies, it is still in at least some formal specifications and not officially deprecated (and as such there is a mismatch with browser compatibility data too). This follows on from discussed in #2902 (comment)

I have not removed the tag "Deprecated" from hgroup which means that it is still listed in HTML elements reference > Obsolete and deprecated elements. That is technically incorrect, but I still don't want to promote it's use.

Note that when/if this is really deprecated we should do a much more thorough tagging exercise as mention of hgroup is scattered through the docs (e.g. anywhere we list that the

@hamishwillee hamishwillee requested review from a team as code owners May 13, 2021 23:40
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team May 13, 2021 23:40
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/HTML/Element
Title: HTML elements reference
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Element/hgroup
Title: <hgroup>
on GitHub

No new external URLs


URL: /en-US/docs/Web/Guide/HTML/Content_categories
Title: Content categories
on GitHub

(this comment was updated 2021-05-14 08:03:25.125274)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @hamishwillee . I've done a few small copy edits, but this is ready to merge now.

@chrisdavidmills chrisdavidmills merged commit f988103 into mdn:main May 14, 2021
@hamishwillee hamishwillee deleted the hgroup_clarify branch May 17, 2021 02:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants