-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagemacro fix4 #4693
Pagemacro fix4 #4693
Conversation
Preview URLs
FlawsNote! 3 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
External URLsURL: URL: URL: URL: No external URLsURL: No external URLs (this comment was updated 2021-05-04 05:48:24.861708) (this comment was updated 2021-05-04 22:19:07.687616) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
I guess, the macro error is not critical.
Thank you!
- Device Orientation | ||
- Mobile | ||
- Orientation | ||
- Property | ||
--- | ||
<p>{{ ApiRef() }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is giving me MacroPagesError for
- globalcrypto (likely meant to point to /en-US/docs/Web/API/Crypto )
- speechsynthesisgetter ( /en-US/docs/Web/API/SpeechSynthesis/getVoices maybe?)
- windowmodal (Lacking the context. /en-US/docs/Web/API/Window/prompt ?)
- onerroreventhandlerforwindow (Likely /en-US/docs/Web/API/GlobalEventHandlers/onerror )
- chromewindow (the browser or the part of a web browser?)
Do you want to address them as part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to address them as part of this PR?
Thanks for spotting these. I'm pretty much fixing the easy flaws along the way, but mostly this is just about PageMacro. Upshot "No".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS These aren't in the page - they are in the sidebar. I do think we should look at them, but not in this.
Part of fixing #3196. Mostly by linking to the original rather than transcluding. But also two case of simply removing the macro