Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Page macro from glossary #4687

Merged
merged 2 commits into from
May 4, 2021

Conversation

hamishwillee
Copy link
Collaborator

As per #3196 we are removing the Page macro (transclusion).

This removes the two usages from the Glossary. In both cases transclusion was used to expand an acronym or close variant of a term (e.g. Denial of Service and DoS Attack). What I did was replace the page call with the first sentence of the transcluded article and a "See XXX for more information".

I also chose to swap the content from Second Level Domain and SDL topics - IMO the master document is the one that is most commonly used, and/or least ambiguous. So in this case I see SDL as ambiguous.

@hamishwillee hamishwillee requested a review from a team as a code owner May 4, 2021 01:28
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team May 4, 2021 01:28
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @hamishwillee !

@chrisdavidmills chrisdavidmills merged commit 4438df5 into mdn:main May 4, 2021
@hamishwillee hamishwillee deleted the pagemacro_fix3 branch May 6, 2021 01:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants