Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Simple RTCDataChannel sample #3892

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Fix typo in Simple RTCDataChannel sample #3892

merged 2 commits into from
Apr 6, 2021

Conversation

Jap2-0
Copy link
Contributor

@Jap2-0 Jap2-0 commented Apr 6, 2021

What was wrong/why is this fix needed? (quick summary only)

Typo - "an load event listener"

MDN URL of main page changed

https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample

Issue number (if there is an associated issue)

None

Anything else that could help us review it

N/A

@Jap2-0 Jap2-0 requested a review from a team as a code owner April 6, 2021 21:03
@Jap2-0 Jap2-0 requested review from sideshowbarker and removed request for a team April 6, 2021 21:03
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
Title: A simple RTCDataChannel sample
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/WebSocket_API
    • Can't resolve /en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_6_support_in_Mozilla

External URLs

URL: /en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
Title: A simple RTCDataChannel sample
on GitHub

Both work right now, but the preview bot complains about them.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

@sideshowbarker sideshowbarker merged commit 40b231f into mdn:main Apr 6, 2021
@sideshowbarker
Copy link
Member

Thanks for catching this and fixing it, and congrats on landing your first docs change here — welcome aboard 🎉

@Jap2-0
Copy link
Contributor Author

Jap2-0 commented Apr 7, 2021

Thank you! MDN has been a great resource for years (and this was a super smooth experience), so I'm glad to have an opportunity to help out.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants