Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept-Charset HTTP header removed - not sent by any browser for many years and deprecated #36854

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Nov 19, 2024

This removes the Accept-Charset header. Not sent by browsers and is deprecated

Historically form elements had an attribute acceptcharset that took same values. This now only takes "UTF-8" if specified, so I tidied that up as well.

@hamishwillee hamishwillee requested review from a team as code owners November 19, 2024 00:04
@hamishwillee hamishwillee requested review from pepelsbey, sideshowbarker, bsmth and estelle and removed request for a team November 19, 2024 00:04
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:HTTP HTTP docs Content:Glossary Glossary entries Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Nov 19, 2024
Copy link
Contributor

Preview URLs (8 pages)
Flaws (40)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/10
Title: Firefox 10 for developers
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/:-moz-full-screen-ancestor does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Updating_add-ons_for_Firefox_10
    • Can't resolve /en-US/docs/PRBool
    • Can't resolve /en-US/docs/Install_Manifests#strictcompatibility
    • Can't resolve /en-US/docs/Extensions/Bootstrapped_extensions#Adding_user_interface_with_a_chrome.manifest

URL: /en-US/docs/Web/HTML/Attributes
Title: HTML attribute reference
Flaw count: 35

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/alt
    • Can't resolve /en-US/docs/Web/HTML/Attributes/autoplay
    • Can't resolve /en-US/docs/Web/HTML/Attributes/cite
    • Can't resolve /en-US/docs/Web/HTML/Attributes/colspan
    • Can't resolve /en-US/docs/Web/HTML/Attributes/controls
    • and 30 more flaws omitted
External URLs (14)

URL: /en-US/docs/Glossary/Forbidden_header_name
Title: Forbidden header name


URL: /en-US/docs/Web/HTTP/Headers
Title: HTTP headers

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I don't see any other leftovers to remove 👍🏻

@sideshowbarker sideshowbarker merged commit 56cbe48 into mdn:main Nov 20, 2024
8 checks passed
yin1999 added a commit to mdn/translated-content that referenced this pull request Nov 21, 2024
yin1999 added a commit to mdn/translated-content that referenced this pull request Nov 21, 2024
* zh-cn: sync translated content

* Accept-Charset HTTP header removed - not sent by any browser for many years and deprecated

ref: mdn/content#36854

---------

Co-authored-by: Allo <yin199909@aliyun.com>
yin1999 added a commit to mdn/translated-content that referenced this pull request Nov 21, 2024
yin1999 added a commit to mdn/translated-content that referenced this pull request Nov 21, 2024
* zh-tw: sync translated content

* Accept-Charset HTTP header removed - not sent by any browser for many years and deprecated

ref: mdn/content#36854

---------

Co-authored-by: Allo <yin199909@aliyun.com>
@hamishwillee hamishwillee deleted the purge_accept_charset branch November 21, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Learn Learning area docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants