Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New css property: SVG cx and cy attributes #34876

Merged
merged 10 commits into from
Jul 23, 2024
Merged

New css property: SVG cx and cy attributes #34876

merged 10 commits into from
Jul 23, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 16, 2024

related to #34763

@estelle estelle requested review from a team as code owners July 16, 2024 22:57
@estelle estelle requested review from chrisdavidmills and removed request for a team July 16, 2024 22:57
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jul 16, 2024
@estelle estelle changed the title CSS properties: cx and cy New css property: SVG cx and cy attributes Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited
Loading

Preview URLs

Flaws (18)

URL: /en-US/docs/Web/CSS/cy
Title: cy
Flaw count: 7

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/y does not exist
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • and 2 more flaws omitted

URL: /en-US/docs/Web/CSS/cx
Title: cx
Flaw count: 7

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/stroke
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/y does not exist
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/fill
    • and 2 more flaws omitted

URL: /en-US/docs/Web/SVG/Attribute/cy
Title: cy
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/y does not exist

URL: /en-US/docs/Web/SVG/Attribute/cx
Title: cx
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/x does not exist
    • /en-US/docs/Web/CSS/y does not exist

(comment last updated: 2024-07-23 15:35:50)

pepelsbey
pepelsbey reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s great to finally see cx/cy coming to CSS! Thanks :) A few suggestions are below.

files/en-us/web/css/cx/index.md Show resolved Hide resolved
files/en-us/web/css/cy/index.md Show resolved Hide resolved
files/en-us/web/css/cx/index.md Outdated Show resolved Hide resolved
@chrisdavidmills chrisdavidmills removed their request for review July 18, 2024 13:14
@estelle estelle requested a review from pepelsbey July 19, 2024 06:38
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

pepelsbey
pepelsbey approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a merge conflict left. Otherwise, looks good! Thank you :)

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 23, 2024
@estelle estelle merged commit 8856986 into main Jul 23, 2024
9 checks passed
@estelle estelle deleted the cxy branch July 23, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @pepelsbey