Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct a subtitle #34016

Closed
wants to merge 1 commit into from
Closed

fix: correct a subtitle #34016

wants to merge 1 commit into from

Conversation

hanyujie2002
Copy link
Contributor

This subtitle was supposed to be modified without doing more research in #26350

## Cross-browser JavaScript problems
In this section, we'll look at some of the more common cross-browser JavaScript problems. We'll break this down into:
- Using modern core JavaScript features
- Using modern Web API features
- Using bad browser sniffing code
- Performance problems

However, the subtitle have correspondence in line 228. The map between the problem list and the subtitles will be broken with the subtitle be modified

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner June 8, 2024 08:34
@hanyujie2002 hanyujie2002 requested review from bsmth and removed request for a team June 8, 2024 08:34
@github-actions github-actions bot added Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs size/xs [PR only] 0-5 LoC changed labels Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone changes the section title, they mean to change the section title. The bug is in what they didn't change, not in what they changed. Please change the anchor links that are outdated instead.

@Josh-Cena
Copy link
Member

I believe the current heading is correct. "Using bad sniffing code" is a common problem and the solution is to "don't browser sniff", because it's almost impossible to write "good sniffing code".

@Josh-Cena Josh-Cena closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants