Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #34002

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix broken link #34002

merged 3 commits into from
Jun 10, 2024

Conversation

3willows
Copy link
Contributor

@3willows 3willows commented Jun 7, 2024

Description

Replaced a broken link from

/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction#introducing_express

with its web archive version

Motivation

Ease of reading / cross referencing

Additional details

Related issues and pull requests

None.

Replaced broken link for "other popular Node web frameworks" with web archive version.
@3willows 3willows requested a review from a team as a code owner June 7, 2024 14:15
@3willows 3willows requested review from teoli2003 and removed request for a team June 7, 2024 14:15
@github-actions github-actions bot added Content:Learn:Express Learning area Express docs size/xs [PR only] 0-5 LoC changed labels Jun 7, 2024
@bsmth
Copy link
Member

bsmth commented Jun 7, 2024

Thanks for opening this one. Note that this was reported here:

The suggestion is to remove the link instead of replace it, which I think is a good idea here.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/Introduction
Title: Express/Node introduction

(comment last updated: 2024-06-10 08:11:41)

@Josh-Cena Josh-Cena linked an issue Jun 8, 2024 that may be closed by this pull request
3willows and others added 2 commits June 10, 2024 15:19
…x.md

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Remove a link to Express Docs which has been removed and will not be replaced
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you!

@bsmth bsmth merged commit e7d7c87 into mdn:main Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Express Learning area Express docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken link to frameworks
3 participants