-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local fonts for font-variant-alternates #27206
Conversation
Preview URLs (comment last updated: 2023-06-08 15:26:24) |
@wbamberg We only support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
@wbamberg , thanks very much for following up, great to see this working in the preview link! https://pr27206.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/font-variant-alternates - Out of curiosity: when does this roll to public MDN? |
MDN is deployed every night between 0am and 1am UTC. |
@wbamberg I looked into it and the reason it doesn't work is that the filename is not lowercase. The filecheck command catches this, but content's content/.github/workflows/pr-test.yml Line 49 in c754ecf
Rather than adding extensions, I would suggest to run the |
@drott , am I right in thinking that in the CSS for the example: .variant {
font-feature-settings: "swsh" 1;
font-variant-alternates: swash(fancy);
} ...the first part So we should remove the first line from this example? |
Or even, include both versions, but in different rules: .variant1 {
font-feature-settings: "swsh" 1;
}
.variant2 {
font-variant-alternates: swash(fancy);
} |
Yes, these are two syntaxes for the same thing. Showing both, describing |
Update https://developer.mozilla.org/en-US/docs/web/css/font-variant-alternates to use a local font, so we can make a live sample work.
This should be possible now mdn/yari#7605 has landed.
Updates #21597.