Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect links to new article location #22381

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Redirect links to new article location #22381

merged 3 commits into from
Nov 21, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 17, 2022

Article has been moved; redirect links to the new location and update content to better reflect where the link goes.

@estelle estelle requested review from a team as code owners November 17, 2022 23:23
@estelle estelle requested review from dipikabh and removed request for a team November 17, 2022 23:23
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Media Media docs Content:Other Any docs not covered by another "Content:" label labels Nov 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Preview URLs

Flaws (6)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/71
Title: Firefox 71 for Developers
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/DataTransfer/mozItemCount does not exist
    • /en-US/docs/Web/API/DataTransfer/mozClearDataAt does not exist
    • /en-US/docs/Web/API/DataTransfer/mozGetDataAt does not exist
    • /en-US/docs/Web/API/DataTransfer/mozSetDataAt does not exist
    • /en-US/docs/Web/API/DataTransfer/mozTypesAt does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/New_in_JavaScript/1.6

(this comment was updated 2022-11-20 17:32:31.579946)

@dipikabh
Copy link
Contributor

Thanks for this update, @estelle!

The fact that the title of the section we're linking to is too long made me look at the TOC of the "Multimedia: Images" page:

Screen Shot 2022-11-17 at 11 53 35 PM

The title "Rendering strategy: preventing jank when loading images" can be shortened (to "Optimizing image rendering strategy") and that would affect the links updated in this PR.

It would help to redo some of the other titles to make them more succinct and parallel in construction:

## Importance of optimizing multimedia
## Optimizing image delivery --> this is not needed. Deleting this title will help move other titles up one level and avoid having h4s
## Optimizing image loading strategy --> (upgraded to h2)
### Using the optimal format --> (upgraded to h3)
### Serving the optimal size --> (upgraded to h3)
### Optimizing image download --> (upgraded to h3)
## Optimizing image rendering strategy --> (upgraded to h2, dropping jank from the title)
## Conclusion
## In this module

I realize that this is more work than what this PR originally sought to do. Let me know what you think.

files/en-us/web/media/images/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh self-assigned this Nov 18, 2022
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
Copy link
Member Author

estelle commented Nov 18, 2022

That can be done in a different PR. This PR was just to get rid of links to a page that no longer exists.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dipikabh dipikabh merged commit 6eefe32 into mdn:main Nov 21, 2022
@estelle estelle deleted the jank branch December 1, 2022 18:27
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
* Redirect links to new article location

* Update files/en-us/web/media/images/index.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Media Media docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants