Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework event bubbling and capture #20013

Merged
merged 9 commits into from
Nov 15, 2022
Merged

Rework event bubbling and capture #20013

merged 9 commits into from
Nov 15, 2022

Conversation

wbamberg
Copy link
Collaborator

Fixes #13749.

This attempts to clarify the description of event bubbling and capture, especially to make it clearer that capture is the non-default option.

@wbamberg wbamberg requested a review from a team as a code owner August 26, 2022 22:30
@wbamberg wbamberg requested review from Elchi3 and removed request for a team August 26, 2022 22:30
@github-actions github-actions bot added the Content:Learn Learning area docs label Aug 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

Preview URLs

Flaws (1)

URL: /en-US/docs/Learn/JavaScript/Building_blocks/Events
Title: Introduction to events
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

(this comment was updated 2022-11-14 16:14:57.597533)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to see this article fixed (I'll need a second to double check, but I think this is mostly good.

wbamberg and others added 4 commits August 26, 2022 16:27
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

Elchi3 and others added 2 commits November 14, 2022 15:41
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Will! 👍

@Elchi3 Elchi3 dismissed teoli2003’s stale review November 15, 2022 10:20

comments addressed

@Elchi3 Elchi3 merged commit c89effa into mdn:main Nov 15, 2022
@wbamberg
Copy link
Collaborator Author

Thank you for fixing this up and dragging it over the line!

hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
* Rework event bubbling and capture

* Update files/en-us/learn/javascript/building_blocks/events/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

* Update files/en-us/learn/javascript/building_blocks/events/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

* Update files/en-us/learn/javascript/building_blocks/events/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

* Update files/en-us/learn/javascript/building_blocks/events/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

* Apply suggestions from code review

Co-authored-by: wbamberg <will@bootbonnet.ca>

* fix multiple blank lines

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@wbamberg wbamberg deleted the fix-13749 branch April 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs
Projects
None yet
3 participants