-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework event bubbling and capture #20013
Conversation
Preview URLs Flaws (1)URL:
(this comment was updated 2022-11-14 16:14:57.597533) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really happy to see this article fixed (I'll need a second to double check, but I think this is mostly good.
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: wbamberg <will@bootbonnet.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Will! 👍
Thank you for fixing this up and dragging it over the line! |
* Rework event bubbling and capture * Update files/en-us/learn/javascript/building_blocks/events/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/learn/javascript/building_blocks/events/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/learn/javascript/building_blocks/events/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/learn/javascript/building_blocks/events/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Apply suggestions from code review Co-authored-by: wbamberg <will@bootbonnet.ca> * fix multiple blank lines Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> Co-authored-by: Florian Scholz <fs@florianscholz.com>
Fixes #13749.
This attempts to clarify the description of event bubbling and capture, especially to make it clearer that capture is the non-default option.