-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARIAMixin #2001
ARIAMixin #2001
Conversation
Should https://github.com/mdn/content/blob/main/files/en-us/web/accessibility/aria/aria_live_regions/index.html be merged/redirected here? |
@nschonni I don't think so, this is the interface. |
Co-authored-by: Joe Medley <jmedley@google.com>
I think the outcome of the discussion here is the answer to my first question above: mdn/browser-compat-data#8929 I'll get on tomorrow with the rest of these. |
@jpmedley here you go, all 41 pages of it. They are all very similar however and based off the initial one you saw, so other than egregious typos hopefully reviewing is not the epic that writing them was! |
I have added the BCD line according to what the suggested new way of doing these is. If that's what we end up going with I can look at adding the compat data for these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rachel,
Thank you for doing this. I know this submission was probably a tedious slog.
Many of the changes I'm asking for need to be done across the collection. Let me know if you need help.
Joe
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
@jpmedley there are a couple of things in the comments but otherwise most of this is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have set some expectations up front. I've rarely seen a PR this large that didn't have require multiple requests for changes. I've never even pulled that off myself. Thank you for your perseverance.
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
@jpmedley I've made the requested changes and fixed the conflict but I can't get github to let me re-request review (I did get git into a bit of a mess with this one). |
@chrisdavidmills This is ready to merge, but we're blocked on BCD. Should we create a label for that? |
@jpmedley so are you after something like "needs-bcd", which would cover general states of PRs for new pages that haven't got BCD available yet, or do you want something more specific than that, which relates to BCD being submitted but not yet merged? And do you think this label should block a content PR being merged? I have mixed feelings about this — I think it is fine to have content available without the corresponding BCD as long as it doesn't spend too long like that, and I feel that if BCD is really complex to unravel and figure out, it would be bad for the page content to be blocked on appearing because of that. |
From what I observed, in these cases, the BCD table would be simply non-existent. |
@chrisdavidmills I had mixed feelings about making the request. Here's the problem I'm trying to solve. Until now, I've mostly done new APIs, which means the BCD work is simple. Version numbers for Chrome and Edge. False for everybody else. Now me and the folks working with me are doing more backlog work, which means other browsers often don't have |
@jpmedley Understood. I think that in these cases it might be worth working out a procedure for trying to get the missing data in, e.g.
I still reckon it is worth having a label to mark work that has this issue. I'd go for something like "bcd-incomplete", and then say that if the data is not found within a week, we should merge the BCD anyway, with null values, then open up a new issue in the BCD repo saying that this data is missing and inviting people to help? |
@jpmedley I have done just one of these properties to check that you are happy with this approach. They are all essentially going to be the same so if we are happy with one it will just be a case of rattling through the others.
Notes:
In our spreadsheet the mixin is listed as AriaAttributes, in the updated spec (and mentioned in the HTML spec) this is now ARIAMixin with updated detail on getting and setting. I think in terms of Element it is essentially still a reflection.
This is taking the approach as discussed in #1940
Two questions:
reviewer @jpmedley