Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt rgb glossary entry with info about sRGB #14890

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

teoli2003
Copy link
Contributor

The RGB glossary entry didn't speak about what a color space is. On the web, the RGB color model represents a color of the sRGB color space.

This PR makes it clearer, without having two glossary entries for RGB and sRGB.

It also speaks a bit about Adobe RGB, because if you copy the components in Photoshop or Illustrator you'll get a different color on the web, as the color spaces are not identical.

This is part of openwebdocs/project#92

@teoli2003 teoli2003 requested a review from estelle April 11, 2022 09:52
@teoli2003 teoli2003 requested a review from a team as a code owner April 11, 2022 09:52
@teoli2003 teoli2003 requested review from ddbeck and removed request for a team April 11, 2022 09:52
@github-actions github-actions bot added the Content:Glossary Glossary entries label Apr 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022

Preview URLs

Flaws

URL: /en-US/docs/Glossary/RGB
Title: RGB
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/GLSL does not exist

External URLs

URL: /en-US/docs/Glossary/RGB
Title: RGB
on GitHub

(this comment was updated 2022-04-12 06:06:54.846118)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tiny copy edits.

files/en-us/glossary/rgb/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/rgb/index.md Outdated Show resolved Hide resolved
teoli2003 and others added 2 commits April 12, 2022 08:04
Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 teoli2003 requested a review from wbamberg April 12, 2022 06:04
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @teoli2003 !

@wbamberg wbamberg merged commit 0654603 into mdn:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants