-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the hsl() page #14651
Reorganize the hsl() page #14651
Conversation
Preview URLsFlawsURL:
External URLsURL:
(this comment was updated 2022-04-07 11:59:36.442472) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
``` | ||
|
||
### Values | ||
|
||
- Functional notation: `hsl(H, S, L[, A])` | ||
- `hue` | ||
- : An {{cssxref("<angle>")}} of the color wheel given in one of the following units: `deg`, `rad`, `grad`, or `turn`. When written as a unitless {{cssxref("<number>")}}, it is interpreted as degrees. By definition, _red_ is `0deg`, with the other colors spread around the circle, so _green_ is `120deg`, _blue_ is `240deg`, etc. As an `<angle>` is periodic, it implicitly wraps around such that `-120deg` = `240deg`, `480deg` = `120deg`, `-1turn` = `1turn?, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a link to the color wheel we can use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added one for the explanation and link to a color picker for hsl() in the See also section. If I find a better hsl color finder, I'll update the page.
committing these two to see if it fixes the rendering. Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: wbamberg <will@bootbonnet.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
I'm creating two glossary entries (sRGB and color wheel) to link from here (and elsewhere), I will add an example and an extra sentence. I will rerequest review when this is done (the glossary entries will be in separate PRs). |
We don't. we just need to update sRGB to explain it and add links from sRGB to sRGB colors. |
👍 I will update the RGB glossary entry tomorrow (or Friday). (In a different PR). |
As it is approved, and feedback addressed I'm merging this, we can do follow-ups if needed. (I still need to update RGB and to get the color wheel glossary entry landed, but this will be in separate PRs) |
This PR is part of openwebdocs/project#92.
The idea here is to simplify the page:
hsla()
is an alias. I put this in the See also section, this will stay prominent inhsla()
as we want to lower its use, but not here.Note that the spec and browser compat sections, although defined correctly, are only partially displayed until mdn/browser-compat-data#15646 is resolved. (This is also the cause of the flaw reported by our Preview URLs bot)
This is the first color function to be reorganized. The idea is to do the same for each of the 7 others.