Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move color keywords into their own page #14615

Merged
merged 7 commits into from
Apr 4, 2022

Conversation

teoli2003
Copy link
Contributor

Part of openwebdocs/project#92 (revamp our color guide and reference).

This PR moves the color keywords into their own page (taking them off the <color> page).

Note that there is much more work to be done on the <color> page, I intentionally limited this PR by moving the color keywords only.

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 3, 2022
@teoli2003 teoli2003 changed the title Move color keywords in their own page Move color keywords into their own page Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/color_value
Title: <color>
on GitHub
Flaw count: 9

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 4 more flaws omitted

External URLs

URL: /en-US/docs/Web/CSS/color_value
Title: <color>
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/color_value/color_keywords
Title: Color keywords
on GitHub

(this comment was updated 2022-04-04 06:28:27.667324)

@teoli2003 teoli2003 marked this pull request as ready for review April 3, 2022 10:10
@teoli2003 teoli2003 requested a review from a team as a code owner April 3, 2022 10:10
@teoli2003 teoli2003 requested review from rachelandrew and removed request for a team April 3, 2022 10:10
</tbody>
</table>

> **Note:** The list of accepted keywords has undergone many changes during the evolution of CSS:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this feels like duplication of the notes you have preceding the table. Could be one of those things you plan on looking at later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is to replace this note with regular Specifications and Browser compatibility sections but I need to restructure the bcd data for <color> for this. (It currently is a kind of a mess)

I'm nevertheless pushing an update. I noticed navigation was not very practical and instead of saying CSS level 1 near the top, I listed the 16 colors and improved the explanation. I think the intro is better now.

@teoli2003 teoli2003 requested a review from hamishwillee April 4, 2022 06:29
@@ -7,15 +7,16 @@ tags:
---
{{CSSRef}}

**Color keywords** are case-insensitive identifiers that represent a specific color, such as `red`, `blue`, `black`, or `lightseagreen`. Although the names more or less describes their respective colors, they are essentially artificial, without a strict rationale behind the names used.
**Color keywords** are case-insensitive identifiers representing a specific color, such as `red`, `blue`, `black`, or `lightseagreen`. Although the names more or less describe their respective colors, they are essentially artificial, without a strict rationale behind the terms used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I would probably have left as "that represent"

- [HTML](/en-US/docs/Web/HTML) only recognizes the 16 basic color keywords found in CSS Level 1, using a specific algorithm to convert unrecognized values (often to completely different colors). The other color keywords should only be used in CSS and [SVG](/en-US/docs/Web/SVG).
- Unlike HTML, CSS will completely ignore unknown keywords.
- The color keywords all represent plain, solid colors, without transparency.
- [HTML](/en-US/docs/Web/HTML) only recognizes the 16 basic color keywords (`black`, `silver`, `gray`, `white`, `maroon`, `red`, `purple`, `fuchsia`, `green`, `lime`, `olive`, `yellow`, `navy`, `blue`, `teal`, and `aqua`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I like this a lot more

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yes, this is not the final product, but happy to merge even so a "better".

@hamishwillee hamishwillee merged commit 1ed886e into mdn:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants