Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageMacro: Remove from HTMLVideoElement.videowidth and tidy #14538

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

hamishwillee
Copy link
Collaborator

HTMLVideoElement.videoWidth was importing a section defining intrinsic width and height from HTMLVideoElement.videoHeight here

I decided rather than duplicating to link to the text from the introduction in HTMLVideoElement.videoWidth - almost as though the information about intrinsic width was a glossary entry.

Also update HTMLVideoElement.videoHeight to tidy the link down to the same information - you don't need "for more info see XXX" when XXX is right there.

Not also, I did consider linking to CSS intrinsic width/height but they are defined quite differently from this.
I couldn't work out how much value there would therefore be in doing so and decided not to.

This is part of removing page macros - see #3196

@hamishwillee hamishwillee requested a review from a team as a code owner April 1, 2022 05:58
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team April 1, 2022 05:58
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Preview URLs

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/HTMLVideoElement/videoHeight"#about_intrinsic_width_and_height
    • Can't resolve /en-US/docs/Web/API/HTMLVideoElement/videoHeight"#about_intrinsic_width_and_height

URL: /en-US/docs/Web/API/HTMLVideoElement/videoHeight
Title: HTMLVideoElement.videoHeight
on GitHub
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
    • /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLVideoElement/videoHeight
Title: HTMLVideoElement.videoHeight
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit da3426d into mdn:main Apr 1, 2022
@hamishwillee hamishwillee deleted the pagemacro_videoelement branch April 3, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants