Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page macro: remove from HTMLFormElement.elements #14537

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Page macro: remove from HTMLFormElement.elements #14537

merged 2 commits into from
Apr 1, 2022

Conversation

hamishwillee
Copy link
Collaborator

HTMLFormElement/elements was using the page macro to import a list of elements from its parent here.

The list was small, so I have simply duplicated it.

This is part of globally removing the page macro: #3196

@hamishwillee hamishwillee requested a review from a team as a code owner April 1, 2022 05:32
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team April 1, 2022 05:32
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/HTMLFormElement/elements
Title: HTMLFormElement.elements
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/HTMLFormElement/elements
Title: HTMLFormElement.elements
on GitHub

No new external URLs

(this comment was updated 2022-04-01 05:35:10.827445)

teoli2003
teoli2003 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@teoli2003 teoli2003 merged commit 2d9ca55 into mdn:main Apr 1, 2022
@hamishwillee hamishwillee deleted the page_htmlformelement_el branch April 1, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @teoli2003