Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RTCSdpType #13916

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove RTCSdpType #13916

merged 1 commit into from
Mar 15, 2022

Conversation

wbamberg
Copy link
Collaborator

This PR removes the separate description of RTCSdpType, and folds its content into the place where it is used. Part of #3196.

@wbamberg wbamberg requested a review from a team as a code owner March 15, 2022 18:29
@wbamberg wbamberg requested review from a team, jpmedley and fiji-flo and removed request for a team March 15, 2022 18:29
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 15, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/RTCSessionDescription
Title: RTCSessionDescription
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCSessionDescription/RTCSessionDescription
Title: RTCSessionDescription()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCSessionDescription/type
Title: RTCSessionDescription.type
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 48a8bbe into mdn:main Mar 15, 2022
@wbamberg wbamberg deleted the remove-RTCSdpType branch October 15, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

@fiji-flo fiji-flo Awaiting requested review from fiji-flo

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @teoli2003