Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTCIceCredentialType dictionary #13915

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

wbamberg
Copy link
Collaborator

This PR removes the RTCIceCredentialType dictionary, which is only used in a single place, and folds its content into the one place where it was used. Part of #3196.

@wbamberg wbamberg requested review from a team as code owners March 15, 2022 17:57
@wbamberg wbamberg requested review from a team, Elchi3 and fiji-flo and removed request for a team March 15, 2022 17:57
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Mar 15, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/68
Title: Firefox 68 for developers
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/linear-gradient() redirects to /en-US/docs/Web/CSS/gradient/linear-gradient()
    • /en-US/docs/Web/CSS/radial-gradient() redirects to /en-US/docs/Web/CSS/gradient/radial-gradient()
    • /en-US/docs/Web/CSS/repeating-radial-gradient() redirects to /en-US/docs/Web/CSS/gradient/repeating-radial-gradient()
    • /en-US/docs/Web/API/SVGElement/focus does not exist
    • /en-US/docs/Web/API/MouseEvent/mozPressure does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox_for_Android

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/68
Title: Firefox 68 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/RTCIceServer
Title: RTCIceServer
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/RTCIceServer/credentialType
Title: RTCIceServer.credentialType
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 👍

@teoli2003
Copy link
Contributor

Let's remove these!

@teoli2003 teoli2003 merged commit 083e626 into mdn:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants