Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RTCNetworkType dictionary #13913

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove RTCNetworkType dictionary #13913

merged 1 commit into from
Mar 15, 2022

Conversation

wbamberg
Copy link
Collaborator

This PR removes the RTCNetworkType dictionary, which is only used in a single place, and folds its content into the one place where it was used. Part of #3196.

@wbamberg wbamberg requested review from a team as code owners March 15, 2022 17:08
@wbamberg wbamberg requested review from a team, sideshowbarker and fiji-flo and removed request for a team March 15, 2022 17:08
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 15, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCIceCandidateStats
Title: RTCIceCandidateStats
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/RTCTransportStats does not exist
  • broken_links:
    • Anchor not lowercase
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/RTCIceCandidateStats
Title: RTCIceCandidateStats
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCIceCandidateStats/networkType
Title: RTCIceCandidateStats.networkType
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wbamberg wbamberg merged commit d30eca0 into mdn:main Mar 15, 2022
@teoli2003
Copy link
Contributor

Ha I forgot to merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

@fiji-flo fiji-flo Awaiting requested review from fiji-flo

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @teoli2003