-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window/isSecureContext→WindowOrWorkerGlobalScope/isSecureContext, and update spec URL #1228
Conversation
It still seems a bit weird that the page URL is |
Good point. I’ll update the patch to move it (along with adding a redirect) — and also change it in the body of the article. |
Well it turns out we do already have https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/isSecureContext — so I’ll make the updates there instead, and just change https://developer.mozilla.org/en-US/docs/Web/API/Window/isSecureContext to a redirect to that. |
6278761
to
8a4cd26
Compare
@domenic updates pushed — please re-review |
8a4cd26
to
54c70e2
Compare
@domenic friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!!
54c70e2
to
403649f
Compare
@jpmedley, @chrisdavidmills This is an easy review that’s already gotten a domain-expert OK but I guess hadn’t been merged yet just due to having merge conflicts. I resolved the conflicts, so it should now be ready for review/merging |
The trouble I have with this PR is that @Elchi3 is currently working on removing all mixin content from MDN, and instead creating pages hanging off the the objects that the mixin-defined properties are actually access from, as it will be a lot less confusing for readers. So Florian, is this change helpful in terms of housekeeping for the mixing work, or should we leave this page where it is? |
Thanks for the ping, Chris! Yeah, so the current idea is to get rid of
I think this PR should be closed as it will be solved with #2427 |
OK, closing per #1228 (comment) |
Fixes #1192