Skip to content

Commit

Permalink
Fold SVGAnimatedPoints (a mixin) into SVGPolygonElement and SVGPolyli…
Browse files Browse the repository at this point in the history
…neElement (#5181)

* Fold SVGAnimatedPoints (a mixin) into SVGPolygonElement and SVGPolylineElement

Redirect it to SVGPolygonElement, an arbitrary choice between the two.

Document animatedPoints in a similar way to animVal here:
https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimatedString

This ignores that the spec requires animatedPoints to be an alias of
points, because that does not match what's actually implemented (yet):
https://svgwg.org/svg2-draft/shapes.html#__svg__SVGAnimatedPoints__animatedPoints
https://wpt.fyi/results/svg/shapes/animatedPoints-non-animated.html?run_id=5709221590990848&run_id=5697986191425536&run_id=5747784122630144&run_id=5742635329257472

* Apply suggestions from code review

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Co-authored-by: Florian Scholz <fs@florianscholz.com>
  • Loading branch information
foolip and Elchi3 authored Jun 3, 2021
1 parent bc5edcf commit 8d8e80b
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 92 deletions.
5 changes: 3 additions & 2 deletions files/en-us/_redirects.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1648,7 +1648,7 @@
/en-US/docs/DOM/SVGAnimatedLengthList /en-US/docs/Web/API/SVGAnimatedLengthList
/en-US/docs/DOM/SVGAnimatedNumber /en-US/docs/Web/API/SVGAnimatedNumber
/en-US/docs/DOM/SVGAnimatedNumberList /en-US/docs/Web/API/SVGAnimatedNumberList
/en-US/docs/DOM/SVGAnimatedPoints /en-US/docs/Web/API/SVGAnimatedPoints
/en-US/docs/DOM/SVGAnimatedPoints /en-US/docs/Web/API/SVGPolygonElement
/en-US/docs/DOM/SVGAnimatedPreserveAspectRatio /en-US/docs/Web/API/SVGAnimatedPreserveAspectRatio
/en-US/docs/DOM/SVGAnimatedRect /en-US/docs/Web/API/SVGAnimatedRect
/en-US/docs/DOM/SVGAnimatedString /en-US/docs/Web/API/SVGAnimatedString
Expand Down Expand Up @@ -3020,7 +3020,7 @@
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedLengthList /en-US/docs/Web/API/SVGAnimatedLengthList
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedNumber /en-US/docs/Web/API/SVGAnimatedNumber
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedNumberList /en-US/docs/Web/API/SVGAnimatedNumberList
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedPoints /en-US/docs/Web/API/SVGAnimatedPoints
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedPoints /en-US/docs/Web/API/SVGPolygonElement
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedPreserveAspectRatio /en-US/docs/Web/API/SVGAnimatedPreserveAspectRatio
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedRect /en-US/docs/Web/API/SVGAnimatedRect
/en-US/docs/Document_Object_Model_(DOM)/SVGAnimatedString /en-US/docs/Web/API/SVGAnimatedString
Expand Down Expand Up @@ -8442,6 +8442,7 @@
/en-US/docs/Web/API/RotationRate.beta /en-US/docs/Web/API/DeviceMotionEvent/rotationRate
/en-US/docs/Web/API/RotationRate.gamma /en-US/docs/Web/API/DeviceMotionEvent/rotationRate
/en-US/docs/Web/API/SVGAElement/SVGAlement.target /en-US/docs/Web/API/SVGAElement/target
/en-US/docs/Web/API/SVGAnimatedPoints /en-US/docs/Web/API/SVGPolygonElement
/en-US/docs/Web/API/SVGElement/dataset /en-US/docs/Web/API/HTMLOrForeignElement/dataset
/en-US/docs/Web/API/SVGElement/onabort /en-US/docs/Web/API/GlobalEventHandlers/onabort
/en-US/docs/Web/API/SVGElement/onblur /en-US/docs/Web/API/GlobalEventHandlers/onblur
Expand Down
10 changes: 0 additions & 10 deletions files/en-us/_wikihistory.json
Original file line number Diff line number Diff line change
Expand Up @@ -76374,16 +76374,6 @@
"Jeremie"
]
},
"Web/API/SVGAnimatedPoints": {
"modified": "2020-10-15T21:10:58.964Z",
"contributors": [
"fscholz",
"abbycar",
"kscarfone",
"Sheppy",
"Jeremie"
]
},
"Web/API/SVGAnimatedPreserveAspectRatio": {
"modified": "2020-10-15T21:09:36.896Z",
"contributors": [
Expand Down
78 changes: 0 additions & 78 deletions files/en-us/web/api/svganimatedpoints/index.html

This file was deleted.

9 changes: 8 additions & 1 deletion files/en-us/web/api/svgpolygonelement/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,14 @@

<h2 id="Properties">Properties</h2>

<p><em>This interface doesn't implement any specific properties, but inherits properties from its parent, {{domxref("SVGGeometryElement")}} and also implements properties from {{domxref("SVGAnimatedPoints")}}.</em></p>
<p><em>This interface also inherits properties from its parent, {{domxref("SVGGeometryElement")}}.</em></p>

<dl>
<dt>{{domxref("SVGPolygonElement.animatedPoints")}} {{readOnlyInline}}</dt>
<dd>A {{DOMxRef("SVGPointList")}} representing the animated value of the element's {{SVGAttr("points")}} attribute. If the {{SVGAttr("points")}} attribute is not being animated, it contains the same value as the <code>points</code> property.</dd>
<dt>{{domxref("SVGPolygonElement.points")}}</dt>
<dd>A {{DOMxRef("SVGPointList")}} representing the base (i.e., static) value of the element's {{SVGAttr("points")}} attribute. Modifications via the {{DOMxRef("SVGPointList")}} object are reflected in the {{SVGAttr("points")}} attribute, and vice versa.</dd>
</dl>

<h2 id="Methods">Methods</h2>

Expand Down
9 changes: 8 additions & 1 deletion files/en-us/web/api/svgpolylineelement/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,14 @@

<h2 id="Properties">Properties</h2>

<p><em>This interface doesn't implement any specific properties, but inherits properties from its parent, {{domxref("SVGGeometryElement")}} and also implements properties from {{domxref("SVGAnimatedPoints")}}.</em></p>
<p><em>This interface also inherits properties from its parent, {{domxref("SVGGeometryElement")}}.</em></p>

<dl>
<dt>{{domxref("SVGPolylineElement.animatedPoints")}} {{readOnlyInline}}</dt>
<dd>A {{DOMxRef("SVGPointList")}} representing the animated value of the element's {{SVGAttr("points")}} attribute. If the {{SVGAttr("points")}} attribute is not being animated, it contains the same value as the <code>points</code> property.</dd>
<dt>{{domxref("SVGPolylineElement.points")}}</dt>
<dd>A {{DOMxRef("SVGPointList")}} representing the base (i.e., static) value of the element's {{SVGAttr("points")}} attribute. Modifications via the {{DOMxRef("SVGPointList")}} object are reflected in the {{SVGAttr("points")}} attribute, and vice versa.</dd>
</dl>

<h2 id="Methods">Methods</h2>

Expand Down

0 comments on commit 8d8e80b

Please sign in to comment.