Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant flags in all browsers for Navigator API #9755

Closed

Conversation

queengooborg
Copy link
Contributor

This PR removes irrelevant flag data for all browsers for the Navigator API as per the corresponding data guidelines.

This PR was created from results of a script designed to remove irrelevant flags.

This PR removes irrelevant flag data for all browsers for the `Navigator` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-flag-data).

This PR was created from results of a [script](https://github.com/vinyldarkscratch/browser-compat-data/blob/scripts/remove-redundant-flags/scripts/remove-redundant-flags.js) designed to remove irrelevant flags.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 4, 2021
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing of this PR would remain if "Enable service workers" is split out. (OK to just rename this one though.)

"flags": [
{
"type": "preference",
"name": "dom.battery.enabled",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm deleting this entry entirely in #9626.

"flags": [
{
"type": "preference",
"name": "Enable service workers"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a PR that removes all of "Enable service workers" in one go? That way is more likely to reveal problems in the data.

@queengooborg
Copy link
Contributor Author

Closing in favor of #9807.

@queengooborg queengooborg deleted the api/Navigator/all-flagremoval branch April 9, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants