Add a guideline for mixins #9016
Conversation
There was a problem hiding this comment.
I've made some suggestions to frame this more as imperative ("do this") rather than as a fact, since it's still aspirational. 😄
I've used the suggestions tool to propose changes, but I don't need you to apply them directly (in fact, they may fail the linter), especially if you have a better wording in mind.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
|
Looks like applying the changes worked just fine :) The diff looks funky to me after the code block, no idea why, though. I agree to merge this in the same release as the other PR! |
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
|
Chris says "I also agree with the BCD approach outlined in #8929". I would say we can merge this. |
|
Let's merge this such that it lands in the same release as #8933 (I'll try to review that today, otherwise, first thing tomorrow). |
It looks like there is consensus in #8929 so here's a PR that adds a data guideline for mixins.