Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLPortalElement #8680

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add HTMLPortalElement #8680

merged 1 commit into from
Jan 21, 2021

Conversation

rachelandrew
Copy link
Collaborator

The API HTMLPortalElement is behind a flag in Chrome.

I'm writing the docs for it, at the moment the MDN page doesn't exist.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 7, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 11, 2021

The first link talks about origin trials. Is the flag the only requirement? Or do you need both the flag and the trial enrollment right now?

@rachelandrew
Copy link
Collaborator Author

To run it on your site you need the origin trial, to play with it you can toggle the flag. Origin Trials let you expose things to people who then don't need to toggle flags.

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 11, 2021

Thanks for the clarification, Rachel. The reason I asked is that, in the past, @jpmedley has asked us to not include features affected by Chrome origin trials. Not sure if that quite applies here. Tagging him for review.

@ddbeck ddbeck requested a review from jpmedley January 11, 2021 17:49
@rachelandrew
Copy link
Collaborator Author

@jpmedley let me know as I'll need to do BCD for the other interfaces and the <portal> element.

@rachelandrew
Copy link
Collaborator Author

Looks like the trial finished in November, so it's just the flags: https://developer.chrome.com/origintrials/#/view_trial/-7680889164480380927

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, checks out. Thank you! 🎉

@ddbeck ddbeck merged commit 7948657 into mdn:master Jan 21, 2021
@ddbeck ddbeck changed the title add BCD for HTMLPortalElement Add HTMLPortalElement Jan 21, 2021
@jpmedley
Copy link
Contributor

MDN has agreed not to include origin trials in BCD. We would prefer that rule for flags as well. MDN accepts flag data, but anyone working for Google is asked to not submit such data.

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 22, 2021

@jpmedley I tested that the element was recognized with the flag on (without origin enrollment), so I'm satisfied that we have not included origin data here.

When it comes to the Chrome flag policy question, I'd refer you to my previous guidance on approaching this problem in #5504 (comment). Policy discussion should take place in #3318 (or a new issue or PR, as needed).

@rachelandrew rachelandrew deleted the HTMLPortalElement branch January 30, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants