-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec_url data in html/global_attributes.json #8064
Add spec_url data in html/global_attributes.json #8064
Conversation
This change adds spec URLs in html/global_attributes.json for all global attributes that have an mdn_url for an MDN article with a Specification(s) table — with the exception that no spec data is added for any cases where a URL found in an MDN Specification(s) table has no fragment-ID part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, thank you! I have some comments to bring in some consistency here but I also see that the spec is not always consistent, so some things are probably fine as is. Also, I realize this is from scraping the wiki, so some choices weren't made by you :-) Let me know what you think!
Co-authored-by: Florian Scholz <fscholz@mozilla.com>
OK, I think I’ve now responded to all review comments, and committed all the suggestions. So if this now looks good, we can merge and move on to the next batch (and if so, let me know what you think that should be). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think I’ve now responded to all review comments, and committed all the suggestions. So if this now looks good, we can merge and move on to the next batch (and if so, let me know what you think that should be).
Thanks! I'm also happy to help with PRs or review anything you submit. Whatever you think is most effective, really.
I'd continue in the html/
folder. Maybe manifest/
next then elements/
(in chunks if needed)?
* Update global attributes spec URLs to match BCD This change aligns the MDN spec URL values for HTML global attributes to sync with the spec URL data we have in BCD. See mdn/browser-compat-data#8064 for discussion on the changes we made to some of the URLs when we added them to BCD. * Update files/en-us/web/html/attributes/autocomplete/index.html Co-authored-by: Florian Scholz <fs@florianscholz.com> Co-authored-by: Florian Scholz <fs@florianscholz.com>
* Update global attributes spec URLs to match BCD This change aligns the MDN spec URL values for HTML global attributes to sync with the spec URL data we have in BCD. See mdn/browser-compat-data#8064 for discussion on the changes we made to some of the URLs when we added them to BCD. * Update files/en-us/web/html/attributes/autocomplete/index.html Co-authored-by: Florian Scholz <fs@florianscholz.com> Co-authored-by: Florian Scholz <fs@florianscholz.com>
* Update global attributes spec URLs to match BCD This change aligns the MDN spec URL values for HTML global attributes to sync with the spec URL data we have in BCD. See mdn/browser-compat-data#8064 for discussion on the changes we made to some of the URLs when we added them to BCD. * Update files/en-us/web/html/attributes/autocomplete/index.html Co-authored-by: Florian Scholz <fs@florianscholz.com> Co-authored-by: Florian Scholz <fs@florianscholz.com>
This change adds spec URLs in
html/global_attributes.json
for all global attributes that have anmdn_url
for an MDN article with a Specification(s) table — with the exception that no spec data is added for any cases where a URL found in an MDN Specification(s) table has no fragment-ID part. Relates to #6765.