Remove never-supported Bluetooth features #6923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
reviewed
Nov 4, 2020
| @@ -1,292 +0,0 @@ | |||
| { | |||
| "api": { | |||
| "BluetoothAdvertisingData": { | |||
There was a problem hiding this comment.
This came from #1689, but without any clues about the implementation status of this.
| @@ -269,102 +269,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "getCharacteristics": { | |||
There was a problem hiding this comment.
Running https://mdn-bcd-collector.appspot.com/tests/api/BluetoothRemoteGATTService/getCharacteristic in Chrome shows this to be supported.
@vinyldarkscratch would you be able to send update PRs for anything Web Bluetooth, to make it easier to review this PR?
There was a problem hiding this comment.
Can confirm this property is supported!
| @@ -467,54 +371,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "isPrimary": { | |||
There was a problem hiding this comment.
It looks like this is actually supported as per https://mdn-bcd-collector.appspot.com/tests/api/BluetoothRemoteGATTService/isPrimary. Can we revert this change?
|
Replaced by #9975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A checklist to help your pull request get merged faster: