-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate MerchantValidationEvent #6889
Deprecate MerchantValidationEvent #6889
Conversation
This change marks MerchantValidationEvent and all its subfeatures standard_track:false and deprecated:true, due to the fact it was all removed from the Payment Request spec: * w3c/payment-request#929 * w3c/payment-request@8337fee https://developer.mozilla.org/en-US/docs/Web/API/MerchantValidationEvent and its sub-articles already updated.
14d7674
to
eea3909
Compare
This is implemented behind a flag in both Chrome and Firefox. Calling it deprecated when it was never even shipped seems a bit weird to me. The definition in https://github.com/mdn/browser-compat-data/blob/master/schemas/compat-data-schema.md#status-information talks about "might be removed in the future or might only be kept for compatibility purposes" and neither really make sense. I'd argue it's more experimental than deprecated, although the fact that it has two implementations would make it non-experimental per the suggested guideline #6905. |
I’d be fine with marking it experimental instead. And given this case, maybe the refinements to our description of experimental being developed #6905 need be broadened to include the sense “an experiment that failed” (or maybe “failed” is too strong a word but instead more like “a historical experiment”, or “an experiment the never ended up reaching maturity”. Anyway, I don’t personally have a strong opinion about experimental vs deprecated for this case. But I do think we need to mark it with one or other — since not doing so leaves the implication that it’s stable, or possibly has a future. |
It's a hard one - but on reflection, I would agree it's not "deprecated". The reality is that it's a Safari-only API for now (and for the foreseeable future). |
I guess that puts this into the category of what we’ve ended up (re)discussing on #6905 To me, the gist of it is, we need to add a new flag to BCD for cases like this, to flag “not an agreed-upon part of the web platform” features. A new flag named simply “single-vendor” would be accurate for doing that in the vast majority of cases. |
Just to making something explicit here: I'm treating making a decision in #6905 as blocking this PR. |
This change marks
MerchantValidationEvent
and all its subfeaturesstandard_track:false
anddeprecated:true,
due to the fact it was all removed from the Payment Request spec:https://developer.mozilla.org/en-US/docs/Web/API/MerchantValidationEvent and its sub-articles already updated.
cc @marcoscaceres