Add linter for experimental+deprecated statuses

scripts/fix/index.js

@@ -9,6 +9,7 @@ import esMain from 'es-main';
 import fixBrowserOrder from './browser-order.js';
 import fixFeatureOrder from './feature-order.js';
 import fixLinks from './links.js';
+import fixStatusContradiction from './status-contradiction.js';
 
 const dirname = fileURLToPath(new URL('.', import.meta.url));
 
@@ -34,6 +35,7 @@ function load(...files) {
         fixBrowserOrder(file);
         fixFeatureOrder(file);
         fixLinks(file);
+        fixStatusContradiction(file);
       }
 
       continue;

scripts/fix/status-contradiction.js

@@ -0,0 +1,38 @@
+/* This file is a part of @mdn/browser-compat-data
+ * See LICENSE file for more information. */
+
+'use strict';
+
+import { readFileSync, writeFileSync } from 'fs';
+import { platform } from 'os';
+
+/** Determines if the OS is Windows */
+const IS_WINDOWS = platform() === 'win32';
+
+const fixStatus = (key, value) => {
+  const status = value?.__compat?.status;
+  if (status && status.experimental && status.deprecated) {
+    status.experimental = false;
+  }
+  return value;
+};
+
+/**
+ * @param {Promise<void>} filename
+ */
+const fixStatusContradiction = (filename) => {
+  let actual = readFileSync(filename, 'utf-8').trim();
+  let expected = JSON.stringify(JSON.parse(actual, fixStatus), null, 2);
+
+  if (IS_WINDOWS) {
+    // prevent false positives from git.core.autocrlf on Windows
+    actual = actual.replace(/\r/g, '');
+    expected = expected.replace(/\r/g, '');
+  }
+
+  if (actual !== expected) {
+    writeFileSync(filename, expected + '\n', 'utf-8');
+  }
+};
+
+export default fixStatusContradiction;

test/lint.js

@@ -20,6 +20,7 @@ import {
   testNotes,
   testPrefix,
   testSchema,
+  testStatusContradiction,
   testStyle,
   testVersions,
 } from './linter/index.js';
@@ -97,6 +98,7 @@ const checkFiles = (...files) => {
           testConsistency(fileData);
           testDescriptions(fileData);
           testPrefix(fileData, filePath);
+          testStatusContradiction(fileData);
           testStyle(rawFileData);
           testVersions(fileData);
           testNotes(fileData);

test/linter/index.js

@@ -9,6 +9,7 @@ import testLinks from './test-links.js';
 import testNotes from './test-notes.js';
 import testPrefix from './test-prefix.js';
 import testSchema from './test-schema.js';
+import testStatusContradiction from './test-status-contradiction.js';
 import testStyle from './test-style.js';
 import testVersions from './test-versions.js';
 
@@ -21,6 +22,7 @@ export {
   testNotes,
   testPrefix,
   testSchema,
+  testStatusContradiction,
   testStyle,
   testVersions,
 };

test/linter/test-status-contradiction.js

@@ -0,0 +1,45 @@
+/* This file is a part of @mdn/browser-compat-data
+ * See LICENSE file for more information. */
+
+import chalk from 'chalk-template';
+import { Logger } from '../utils.js';
+
+/**
+ * @typedef {import('../../types').Identifier} Identifier
+ */
+
+/**
+ * @param {Identifier} data
+ * @param {Logger} logger
+ */
+function checkStatus(data, logger, path = []) {
+  const status = data.__compat?.status;
+  if (status && status.experimental && status.deprecated) {
+    logger.error(
+      chalk`{red Unexpected simultaneous experimental and deprecated status in ${path.join(
+        '.',
+      )}}`,
+    );
+  }
+  for (const member in data) {
+    if (member === '__compat') {
+      continue;
+    }
+    checkStatus(data[member], logger, [...path, member]);
+  }
+}
+
+/**
+ * @param {Identifier} data The contents of the file to test
+ * @returns {boolean} If the file contains errors
+ */
+function testStatusContradiction(data) {
+  const logger = new Logger('Flag consistency');
+
+  checkStatus(data, logger);
+
+  logger.emit();
+  return logger.hasErrors();
+}
+
+export default testStatusContradiction;