Update display values to non-experimental; remove display: subgrid #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to set them as non-experimental! For PR's sake, I think we should split out the removal of |
Elchi3
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a whole bunch of values marked experimental, including
grid,inline-grid,contentswhich are not experimental.I also removed
display: subgridI don't think it makes sense to be here. It was never implemented in any browser, and was part of a suggestion in terms of how to create the subgrid feature, which went up against the single-dimensional model agreed on as values forgrid-template-columnsandgrid-template-rows. I think leaving it here may well just confuse people.