Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate stringly typed versions #485

Merged
merged 2 commits into from
Oct 8, 2017
Merged

Invalidate stringly typed versions #485

merged 2 commits into from
Oct 8, 2017

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Oct 8, 2017

It's currently possible to enter values for version_added and version_removed like "true" instead of true or "null" instead of null. This PR changes the schema to make "true", "false", and "null" unacceptable values for versions.

teoli2003
teoli2003 approved these changes Oct 8, 2017
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I manually checked "true" the other day (to put true), but forgot about "false".
Good catch and good change to the schema.

@teoli2003 teoli2003 merged commit 5fc60a7 into mdn:master Oct 8, 2017
@ddbeck ddbeck deleted the invalidate_stringly_typed_versions branch October 8, 2017 20:39
@Elchi3 Elchi3 added the schema Isses or pull requests regarding the JSON schema files used in this project. label Oct 10, 2017
@ddbeck ddbeck mentioned this pull request Mar 7, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 24, 2022
Open
@Woodpile37 Woodpile37 mentioned this pull request Aug 22, 2023
Merged
@Aknc34 Aknc34 mentioned this pull request Jan 3, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 4, 2024
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddbeck @teoli2003 @Elchi3