Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec_url to schema doc #4507

Merged
merged 3 commits into from
Jul 18, 2019
Merged

Add spec_url to schema doc #4507

merged 3 commits into from
Jul 18, 2019

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jul 18, 2019

Fixes #4466

@Elchi3 Elchi3 added the docs Issues or pull requests regarding the documentation of this project. label Jul 18, 2019
ddbeck
ddbeck requested changes Jul 18, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Florian. I have just one suggestion for you

schemas/compat-data-schema.md Outdated Show resolved Hide resolved
@Elchi3 @ddbeck
Update schemas/compat-data-schema.md
427d8a0 
Co-Authored-By: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
ddbeck approved these changes Jul 18, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ddbeck ddbeck merged commit 6e16620 into master Jul 18, 2019
@ddbeck ddbeck deleted the docs-spec_url branch July 18, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
docs Issues or pull requests regarding the documentation of this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document spec_url
2 participants
@Elchi3 @ddbeck