Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(real‑values): Fix broken chalk tagged template literal call #4480

Merged
merged 1 commit into from
Jul 11, 2019
Merged

test(real‑values): Fix broken chalk tagged template literal call #4480

merged 1 commit into from
Jul 11, 2019

Conversation

ExE-Boss
Copy link
Contributor

Bug introduced by: #4265

Previously, the top level red chalk tag was unclosed, this fixes it.

@ExE-Boss ExE-Boss requested a review from Elchi3 as a code owner July 11, 2019 14:03
Elchi3
Elchi3 approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 👍

@Elchi3 Elchi3 merged commit d0f6ffd into mdn:master Jul 11, 2019
@Elchi3 Elchi3 added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Jul 11, 2019
@ExE-Boss ExE-Boss deleted the test/real-values/fix-chalk-tag branch July 11, 2019 15:24
@ExE-Boss ExE-Boss mentioned this pull request Jul 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExE-Boss @Elchi3