Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update :-webkit-autofill compat data #4118

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented May 9, 2019

So, I'm trying to wrap my head around how to do archaeology for certain CSS features where we need real values and if it is worth it :) So, here's what I did for this very old feature where we only had true values:

I figured from the name that this is a webkit invention and it must have made its way into the other browsers through engine forking. So, my journey begins at searching https://github.com/WebKit/webkit/ searching for "autofill" and using git blame.

I found WebKit/WebKit@174364d which in the changelog file says "Added autofill string for "-khtml-autofill" and also other files in the diff give hints that this commit is likely the one that implemented this. This was committed on 13 Apr 2006.

Only 2 days later, 15 Apr 2006, in WebKit/WebKit@21d3140, it was renamed to "-webkit-autofill".

Now I took the date, 15 Apr 2006, and looked up Safari releases in our browser folder and the next one after this date is Safari 3. ("release_date": "2007-11-14"). We don't have safari iOS release dates, so I don't know which one it could be.

As Chromium forked from webkit much later (2008), the true value can be changed to 1.
Other forks that then happened from Chromium are even later, so I've set their first release version respectively as well.

I'm sure Edge didn't implement this non-standard behavior, so I went from null to false.

@Elchi3 Elchi3 added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 9, 2019
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job chasing this one down! This lines up with what I found as well, with sources to help back it up. I'd say that Safari iOS can be dealt with once #2006 is all ready to go, so we can pair desktop and mobile versions.

Overall, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants