Update :-webkit-autofill compat data #4118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm trying to wrap my head around how to do archaeology for certain CSS features where we need real values and if it is worth it :) So, here's what I did for this very old feature where we only had true values:
I figured from the name that this is a webkit invention and it must have made its way into the other browsers through engine forking. So, my journey begins at searching https://github.com/WebKit/webkit/ searching for "autofill" and using git blame.
I found WebKit/WebKit@174364d which in the changelog file says "Added autofill string for "-khtml-autofill" and also other files in the diff give hints that this commit is likely the one that implemented this. This was committed on 13 Apr 2006.
Only 2 days later, 15 Apr 2006, in WebKit/WebKit@21d3140, it was renamed to "-webkit-autofill".
Now I took the date, 15 Apr 2006, and looked up Safari releases in our browser folder and the next one after this date is Safari 3. (
"release_date": "2007-11-14"
). We don't have safari iOS release dates, so I don't know which one it could be.As Chromium forked from webkit much later (2008), the
true
value can be changed to 1.Other forks that then happened from Chromium are even later, so I've set their first release version respectively as well.
I'm sure Edge didn't implement this non-standard behavior, so I went from
null
tofalse
.