Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compile_flag from the schema #3752

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Remove compile_flag from the schema #3752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
983a1e9
Remove the two instances of compile_flag
ddbeck Apr 1, 2019
4f8c791
Remove supporting code for compile_flag
ddbeck Apr 1, 2019
6bb506b
Remove compile_flag from the schema
ddbeck Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions api/Document.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5852,18 +5852,10 @@
},
"firefox": [
{
"version_added": "61",
"version_removed": "63",
"flags": [
{
"type": "compile_flag",
"name": "MOZ_BREAK_XUL_OVERLAYS",
"value_to_set": "False"
}
],
"version_added": true,
"version_removed": "61",
"notes": [
"Available only to <a href='https://developer.mozilla.org/docs/Mozilla/Tech/XUL'>XUL documents</a>.",
"If a XUL document attempts to load an overlay without the compile flag, an error will be thrown (see <a href='https://bugzil.la/1448162'>bug 1448162</a>).",
"See <a href='https://bugzil.la/1449791'>bug 1449791</a>"
]
},
Expand Down
16 changes: 2 additions & 14 deletions javascript/operators/pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,10 @@
"version_added": false
},
"firefox": {
"version_added": "58",
"flags": [
{
"name": "--enable-pipeline-operator",
"type": "compile_flag"
}
]
"version_added": false
},
"firefox_android": {
"version_added": "58",
"flags": [
{
"name": "--enable-pipeline-operator",
"type": "compile_flag"
}
]
"version_added": false
},
"ie": {
"version_added": false
Expand Down
1 change: 0 additions & 1 deletion schemas/compat-data-schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ array will have one item, but there are cases where two or more flags can be req
An object in the `flags` array consists of three properties:
* `type` (mandatory): an enum that indicates the flag type:
* `preference` a flag the user can set (like in `about:config` in Firefox).
* `compile_flag` a flag to be set before compiling the browser.
* `runtime_flag` a flag to be set before starting the browser.
* `name` (mandatory): a string giving the value which the specified flag must be set to for this feature to work.
* `value_to_set` (optional): representing the actual value to set the flag to.
Expand Down
2 changes: 1 addition & 1 deletion schemas/compat-data.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"type": {
"type": "string",
"description": "An enum that indicates the flag type.",
"enum": ["preference", "compile_flag", "runtime_flag"]
"enum": ["preference", "runtime_flag"]
},
"name": {
"type": "string",
Expand Down
4 changes: 0 additions & 4 deletions scripts/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,6 @@ function writeFlagsNote(supportData, browserId) {
output += `${flagText} preference${valueToSet}. ${prefSettings}`;
}

if (supportData.flag.type === 'compile_flag') {
output += `${flagText} compile flag${valueToSet}.`;
}

return output;
}

Expand Down
3 changes: 1 addition & 2 deletions types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,9 @@ export interface SimpleSupportStatement {
/**
* An enum that indicates the flag type:
* - `preference` a flag the user can set (like in `about:config` in Firefox).
* - `compile_flag` a flag to be set before compiling the browser.
* - `runtime_flag` a flag to be set before starting the browser.
*/
type: 'preference' | 'compile_flag' | 'runtime_flag';
type: 'preference' | 'runtime_flag';

/**
* A `string` representing the flag or preference to modify.
Expand Down