-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark some CSS properties as supported in specific versions of Edge #3667
Conversation
This is based on results from Edge 12-18: https://github.com/foolip/mdn-bcd-results/tree/e16e4ca1e51625a7d720dd926b0ab41268d8c11c Tests on the form `'propertyName' in document.body.style` were used. The script to update BCD is under development: https://gist.github.com/foolip/eacef197c5ef52e85917dc64cf8d8358 The earliest supported version was added `version_added`. These changes were hand picked from the output.
I pushed another commit to include two that went from false to a specific version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I have some doubts on a few here. Would appreciate a look.
css/properties/ime-mode.json
Outdated
@@ -12,7 +12,7 @@ | |||
"version_added": null | |||
}, | |||
"edge": { | |||
"version_added": null | |||
"version_added": "12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18922787/ says "Edge removed ime-mode for interoperability reasons". So maybe it was supported for a few versions, but we also need a "version_removed" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test did return true in Edge 12-18 (checked manually now) and the script I used shouldn't have added this if it had been removed again.
https://software.hixie.ch/utilities/js/live-dom-viewer/saved/6806 tests using CSS.supports
instead, and I just confirmed it returning true in Edge 18.
It seems like perhaps they left the property but disabled the behavior.
@gked, if you are the "Grisha L." in https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18922787/, can you shed some light on what happened here?
@Elchi3 I've reverted the ime-mode change, leaving it as null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, then we're all set here for now. 👍
This is based on results from Edge 12-18:
https://github.com/foolip/mdn-bcd-results/tree/e16e4ca1e51625a7d720dd926b0ab41268d8c11c
Tests on the form
'propertyName' in document.body.style
were used.The script to update BCD is under development:
https://gist.github.com/foolip/eacef197c5ef52e85917dc64cf8d8358
The earliest supported version was added
version_added
. Thesechanges were hand picked from the output.