Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter: Ensure version_added earlier than version_removed #3370

Merged
merged 6 commits into from
Feb 4, 2019
Merged

Linter: Ensure version_added earlier than version_removed #3370

merged 6 commits into from
Feb 4, 2019

Conversation

queengooborg
Copy link
Contributor

Fixes #1660.

ExE-Boss
ExE-Boss suggested changes Feb 2, 2019
View reviewed changes
test/test-versions.js Outdated Show resolved Hide resolved
@ExE-Boss @queengooborg
Update version check in test/test-versions.js
a0cbae0 
Co-Authored-By: vinyldarkscratch <vinyldarkscratch@gmail.com>
ExE-Boss
ExE-Boss suggested changes Feb 2, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
ExE-Boss
ExE-Boss approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@Elchi3 Elchi3 added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Feb 4, 2019
@ddbeck ddbeck requested a review from Elchi3 February 4, 2019 11:25
Elchi3
Elchi3 approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! I think the devDependency is fine, it looks like a small package with no further dependencies and it does the job well, I think.

Let's just put the correct version_added for TypedArray#move and we're done here 👍

javascript/builtins/TypedArray.json Outdated Show resolved Hide resolved
@ExE-Boss @queengooborg
Update javascript/builtins/TypedArray.json
6bfc189 
Co-Authored-By: vinyldarkscratch <vinyldarkscratch@gmail.com>
@queengooborg
Copy link
Contributor Author

Change committed!

@Elchi3
Copy link
Member

Elchi3 commented Feb 4, 2019

Awesome! Thanks again! :)

@Elchi3 Elchi3 merged commit 49681ec into mdn:master Feb 4, 2019
@queengooborg queengooborg deleted the linter/version-added-before-removed branch February 4, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@ExE-Boss ExE-Boss ExE-Boss approved these changes

Assignees
No one assigned
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @Elchi3 @ExE-Boss