Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort browsers for http/* #2899

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Sort browsers for http/* #2899

merged 1 commit into from
Oct 4, 2018

Conversation

queengooborg
Copy link
Contributor

No description provided.

@Elchi3 Elchi3 added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Oct 2, 2018
@ExE-Boss
Copy link
Contributor

ExE-Boss commented Oct 2, 2018

@Elchi3 This should be data:http 🚠, not data:js 📟.

ExE-Boss
ExE-Boss reviewed Oct 2, 2018
View reviewed changes
http/data-url.json Outdated
"version_added": "12",
"notes": "The maximum size supported is 4GB"
"notes": "The maximum size supported is 4GB",
"version_added": "12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer keeping version_added and version_removed at the top.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my editor might have assumed I wanted to sort the grandchildren as well (which is not accurate). Whoops!

@Elchi3 Elchi3 added data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP and removed data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Oct 2, 2018
@queengooborg queengooborg mentioned this pull request Oct 2, 2018
Merged
ExE-Boss
ExE-Boss suggested changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still more issues.

You should start over by doing git checkout -B sort-http master and then running sort-browsers.js in node.

Afterwards, you’ll have to do a git push -f.

http/headers/cache-control.json Outdated
"version_added": false,
"notes": "See Chromium <a href='https://code.google.com/p/chromium/issues/detail?id=348877'>bug 348877</a>."
"notes": "See Chromium <a href='https://code.google.com/p/chromium/issues/detail?id=348877'>bug 348877</a>.",
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/cache-control.json Outdated
"version_added": false,
"notes": "See Bugzilla <a href='https://bugzil.la/995651'>bug 995651</a>."
"notes": "See Bugzilla <a href='https://bugzil.la/995651'>bug 995651</a>.",
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/cache-control.json Outdated
"version_added": false,
"notes": "See Chromium <a href='https://code.google.com/p/chromium/issues/detail?id=348877'>bug 348877</a>."
"notes": "See Chromium <a href='https://code.google.com/p/chromium/issues/detail?id=348877'>bug 348877</a>.",
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/cache-control.json Outdated
"version_added": false,
"notes": "See Bugzilla <a href='https://bugzil.la/995651'>bug 995651</a>."
"notes": "See Bugzilla <a href='https://bugzil.la/995651'>bug 995651</a>.",
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/content-security-policy.json Outdated
"version_added": "25",
"notes": "Implemented as X-Webkit-CSP header in Chrome 14."
"notes": "Implemented as X-Webkit-CSP header in Chrome 14.",
"version_added": "25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/content-security-policy.json Outdated
"version_added": "33",
"notes": "Before Firefox 58, <code>frame-ancestors</code> is ignored in <code>Content-Security-Policy-Report-Only</code>."
"notes": "Before Firefox 58, <code>frame-ancestors</code> is ignored in <code>Content-Security-Policy-Report-Only</code>.",
"version_added": "33"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/content-security-policy.json Outdated
"version_added": "33",
"notes": "Before Firefox for Android 58, <code>frame-ancestors</code> is ignored in <code>Content-Security-Policy-Report-Only</code>."
"notes": "Before Firefox for Android 58, <code>frame-ancestors</code> is ignored in <code>Content-Security-Policy-Report-Only</code>.",
"version_added": "33"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/content-security-policy.json Outdated
"version_added": false,
"notes": "See <a href='https://bugzil.la/1045899'>bug 1045899</a>."
"notes": "See <a href='https://bugzil.la/1045899'>bug 1045899</a>.",
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/content-security-policy.json Outdated
"version_added": false,
"notes": "<a href='https://developer.microsoft.com/en-us/microsoft-edge/platform/status/cspupgradeinsecurerequestsdirective'>Under consideration</a> for future release."
"notes": "<a href='https://developer.microsoft.com/en-us/microsoft-edge/platform/status/cspupgradeinsecurerequestsdirective'>Under consideration</a> for future release.",
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

http/headers/content-security-policy.json Outdated
"version_added": "59",
"notes": "Chrome 59 and higher skips the deprecated <code>child-src</code> directive."
"notes": "Chrome 59 and higher skips the deprecated <code>child-src</code> directive.",
"version_added": "59"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Elchi3
Elchi3 approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 👍

@Elchi3 Elchi3 merged commit 56f434d into mdn:master Oct 4, 2018
@queengooborg queengooborg deleted the sort-http branch October 4, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExE-Boss ExE-Boss ExE-Boss requested changes

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @ExE-Boss @Elchi3