Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove html.elements.{area,object}.tabindex & Update html.global_attributes.tabindex #24430

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Remove html.elements.{area,object}.tabindex & Update html.global_attributes.tabindex #24430

merged 2 commits into from
Sep 18, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 13, 2024 •
edited
Loading

Summary

this can be a follow up to #7310 and part of the #21810

the attribute is defined on the global_attributes itself and should not defined on detailed html elements again

  1. Remove html.elements.{area,object}.tabindex (most data are the same, except for the firefox one, assume the global one (and HTML interface one) is correct)
  2. Update html.global_attributes.tabindex (opera: data taken from the same property of HTMLElement)

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Sep 13, 2024
@skyclouds2001 skyclouds2001 mentioned this pull request Sep 13, 2024
Open
@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 13, 2024 11:03
Elchi3
Elchi3 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit c9525cc into mdn:main Sep 18, 2024
5 checks passed
@skyclouds2001 skyclouds2001 deleted the tabindex branch September 18, 2024 12:43
@Elchi3 Elchi3 mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @Elchi3