Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support-for-execution-world-MAIN #23539

Merged
merged 6 commits into from
Jul 2, 2024
Merged

support-for-execution-world-MAIN #23539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd6220e
support-for-execution-world-MAIN
rebloor Jun 27, 2024
6c9d659
Support for world in content_scripts
rebloor Jun 28, 2024
5f25e18
Update from feedback on content
rebloor Jul 2, 2024
4f1162b
Further feedback updates
rebloor Jul 2, 2024
721e803
Merge branch 'main' into support-for-execution-world-MAIN
rebloor Jul 2, 2024
f49fbfc
scripting.executeScript.world ISOLATED and MAIN dtails
rebloor Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions webextensions/api/contentScripts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,24 @@
"webextensions": {
"api": {
"contentScripts": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/contentScripts",
"support": {
"chrome": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "59"
},
"firefox_android": "mirror",
"opera": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror"
}
},
"RegisteredContentScript": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/contentScripts/RegisteredContentScript",
Expand Down Expand Up @@ -98,6 +116,25 @@
"safari_ios": "mirror"
}
}
},
"world": {
"__compat": {
"support": {
"chrome": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "128"
},
"firefox_android": "mirror",
"opera": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror"
}
}
}
}
}
Expand Down
44 changes: 40 additions & 4 deletions webextensions/api/scripting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false,
"impl_url": "https://bugzil.la/1736575"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also drop the note from

browser-compat-data/webextensions/api/scripting.json

Line 312 in 6bba19c

"notes": "Only supports <code>ISOLATED</code>, not <code>MAIN</code>."

"version_added": "128"
},
"firefox_android": "mirror",
"opera": "mirror",
Expand Down Expand Up @@ -308,8 +307,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": "102",
"notes": "Only supports <code>ISOLATED</code>, not <code>MAIN</code>."
"version_added": "102"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Someone skimming this could mistakenly think that MAIN is supported in 102. Could you add multiple ranges to clarify that 102 only introduced support for ISOLATED, and 128 also added support for MAIN?

},
"firefox_android": "mirror",
"opera": "mirror",
Expand All @@ -318,6 +316,44 @@
},
"safari_ios": "mirror"
}
},
"ISOLATED": {
"__compat": {
"support": {
"chrome": {
"version_added": "95"
},
"edge": "mirror",
"firefox": {
"version_added": "102"
},
"firefox_android": "mirror",
"opera": "mirror",
"safari": {
"version_added": "15.4"
},
"safari_ios": "mirror"
}
}
},
"MAIN": {
"__compat": {
"support": {
"chrome": {
"version_added": "95"
},
"edge": "mirror",
"firefox": {
"version_added": "128"
},
"firefox_android": "mirror",
"opera": "mirror",
"safari": {
"version_added": "15.4"
},
"safari_ios": "mirror"
}
}
}
}
},
Expand Down
3 changes: 1 addition & 2 deletions webextensions/manifest/content_scripts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": false,
"impl_url": "https://bugzil.la/1736575"
"version_added": "128"
},
"firefox_android": "mirror",
"opera": "mirror",
Expand Down