Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix experimental+deprecated statuses #15913

Merged
merged 6 commits into from
May 16, 2022
Merged

Conversation

saschanaz
Copy link
Contributor

Summary

Copied from #6813.

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 20, 2022
@queengooborg queengooborg self-requested a review April 20, 2022 15:32
@foolip
Copy link
Contributor

foolip commented Apr 20, 2022

All of these change experimental. Was there really no case where the mistake was the other way around?

@saschanaz
Copy link
Contributor Author

saschanaz commented Apr 20, 2022

All of these change experimental. Was there really no case where the mistake was the other way around?

I assumed that deprecated flags were valid, I didn't reevaluate them 🤔

@saschanaz
Copy link
Contributor Author

saschanaz commented Apr 24, 2022

Better to merge #15932 first I guess. (Or should this one be first?)

@foolip
Copy link
Contributor

foolip commented Apr 24, 2022

I'd say this one first, because it's easier to reason about and will probably reduce the number of inheritance fixes needed.

@foolip
Copy link
Contributor

foolip commented Apr 24, 2022

Hmm, but fixing #11506 before this would also be good, it's mechanical and probably makes many of the same changes.

@queengooborg what do you think of the order of all these status changes?

@queengooborg
Copy link
Contributor

My preference would be to perform migration 007 (#11506) first. It's a change I feel a little more confident about and is just about ready to go, plus it follows the migration steps.

@github-actions
Copy link

github-actions bot commented May 9, 2022

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions github-actions bot added data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML and removed rebase needed 🚧 labels May 9, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions github-actions bot added data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP and removed rebase needed 🚧 labels May 13, 2022
@foolip
Copy link
Contributor

foolip commented May 13, 2022

@saschanaz I tried to resolve the merge conflict but think I messed it up. Do you want to throw away my merge commit and fix it yourself? I expect a lot fewer changes now that #16285 landed.

@saschanaz
Copy link
Contributor Author

Well, I think the number of changed files are still similar 👀

@foolip
Copy link
Contributor

foolip commented May 14, 2022

Huh, I thought it would make a big dent, but OK then.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've look through all of the changes using npm run diff and to my surprise couldn't spot any cases where it actually shouldn't be deprecated.

@foolip foolip merged commit ffe76bc into mdn:main May 16, 2022
@saschanaz saschanaz deleted the fix-experimental branch May 16, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants