-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix experimental+deprecated statuses #15913
Conversation
All of these change experimental. Was there really no case where the mistake was the other way around? |
I assumed that |
Better to merge #15932 first I guess. (Or should this one be first?) |
I'd say this one first, because it's easier to reason about and will probably reduce the number of inheritance fixes needed. |
Hmm, but fixing #11506 before this would also be good, it's mechanical and probably makes many of the same changes. @queengooborg what do you think of the order of all these status changes? |
My preference would be to perform migration 007 (#11506) first. It's a change I feel a little more confident about and is just about ready to go, plus it follows the migration steps. |
This pull request has merge conflicts that must be resolved before we can merge this. |
This pull request has merge conflicts that must be resolved before we can merge this. |
@saschanaz I tried to resolve the merge conflict but think I messed it up. Do you want to throw away my merge commit and fix it yourself? I expect a lot fewer changes now that #16285 landed. |
Well, I think the number of changed files are still similar 👀 |
Huh, I thought it would make a big dent, but OK then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've look through all of the changes using npm run diff
and to my surprise couldn't spot any cases where it actually shouldn't be deprecated.
Summary
Copied from #6813.
Test results and supporting details
Related issues